From 28a57130570b7ca2f97456fa13f29d75e8388939 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timoth=C3=A9e?= <tpoussard@neogeo.fr>
Date: Thu, 2 Jun 2022 16:21:33 +0200
Subject: [PATCH] fix popup link to feature undefined id

---
 src/services/map-service.js | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/services/map-service.js b/src/services/map-service.js
index 530f832a..a55a86cf 100644
--- a/src/services/map-service.js
+++ b/src/services/map-service.js
@@ -113,7 +113,6 @@ const mapService = {
   
   addRouterToPopup(featureTypeSlug, featureId) {
     function goToFeatureDetail() {
-      console.log(featureTypeSlug, featureId);
       router.push({
         name: 'details-signalement',
         params: {
@@ -393,7 +392,6 @@ const mapService = {
           color : '#000000';
 
     const rgbaColor = asArray(colorValue);
-    console.log({ featureType, properties });
     //* set opacity from feature-type colors_style
     rgbaColor[3] = this.retrieveFeatureOpacity(featureType, properties) || 0.5;//opacity
     const hiddenStyle = new Style();
@@ -545,7 +543,7 @@ const mapService = {
                   </div>
                   ${author}
                   `;
-    const featureId = feature.getProperties ? feature.getProperties().feature_id : feature.id;
+    const featureId = feature.getProperties ? feature.getProperties().feature_id || feature.getId() : feature.id; //* feature.id was used with leaflet, with ol feature.getId replace it, but keeping it as fallback can prevent regression
     return { html, feature_type, featureId };
   },
 
-- 
GitLab